Arm backend: Backend flow should not share compile spec object#15632
Merged
Sebastian-Larsson merged 1 commit intopytorch:mainfrom Nov 6, 2025
Conversation
Delay compile-spec creation in the backend test flow to prevent sharing the temp directory between tests. Previously, using a shared compile spec implied a shared temp directory. After we began cleaning the temp directory after each test, this sharing caused conflicts. Signed-off-by: Zingo Andersen <Zingo.Andersen@arm.com> Change-Id: I3a45ade598924751fa1b3fd73631732788350345
zingo
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15632
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (5 Unrelated Failures)As of commit 4da688a with merge base d07a49a ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Collaborator
Author
|
Test fails unrelated |
Sebastian-Larsson
approved these changes
Nov 6, 2025
Collaborator
Author
|
Fails unrelated, no buck2 changes should be needed for this. |
abhinaykukkadapu
pushed a commit
to abhinaykukkadapu/executorch
that referenced
this pull request
Nov 6, 2025
…ch#15632) ### Summary Delay compile-spec creation in the backend test flow to prevent sharing the temp directory between tests. Previously, using a shared compile spec implied a shared temp directory. After we began cleaning the temp directory after each test, this sharing caused conflicts. ### Test plan This is tested by the Backend test flow Signed-off-by: Zingo Andersen <Zingo.Andersen@arm.com>
jirioc
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Dec 19, 2025
…ch#15632) ### Summary Delay compile-spec creation in the backend test flow to prevent sharing the temp directory between tests. Previously, using a shared compile spec implied a shared temp directory. After we began cleaning the temp directory after each test, this sharing caused conflicts. ### Test plan This is tested by the Backend test flow Signed-off-by: Zingo Andersen <Zingo.Andersen@arm.com>
zingo
deleted the
Arm-backend-Backend-flow-should-not-share-compile-spec-object
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delay compile-spec creation in the backend test flow to prevent sharing the temp directory between tests.
Previously, using a shared compile spec implied a shared temp directory. After we began cleaning the temp directory after each test, this sharing caused conflicts.
Test plan
This is tested by the Backend test flow
cc @freddan80 @per @oscarandersson8218 @digantdesai