Cortex_M backend: Add conv op#15896
Merged
AdrianLundell merged 2 commits intopytorch:mainfrom Nov 20, 2025
Merged
Conversation
Currently only support for NHWC memory format. Adds weights-per-tensor quantization as default quantization. Generalizes the CortexMPassManager to work with any pass with exported_program as init arg to support using both XNNPackPasses and ArmPasses. Refactors the QuantizedLinearFusionPass to become a more general CovertToCortexMPass for replacing Aten ops with corresponding Cortex-M ops. Note that this pass and quantized_op_fusion_pass have the same function except that the former uses call() and the latter uses the call_operator() function. This is likely to be refactored in a future patch. Signed-off-by: Adrian Lundell <adrian.lundell@arm.com> Change-Id: I7f809550bcc706f5b08bf1597a519b66801489af
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15896
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 5e56eb0 with merge base 3374ff8 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zingo
approved these changes
Nov 20, 2025
Collaborator
Author
|
Unrelated failures |
Collaborator
|
This might have caused some problems |
AdrianLundell
added a commit
to AdrianLundell/executorch
that referenced
this pull request
Nov 20, 2025
Backfix after pytorch#15896 Signed-off-by: Adrian Lundell <adrian.lundell@arm.com> Change-Id: Ic1ed12afb37e6998b0d28cf7140f6b198e3a2cb1
Collaborator
Author
|
This should be fixed with #15916 |
zingo
pushed a commit
that referenced
this pull request
Nov 20, 2025
quck-fix after #15896 cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai Signed-off-by: Adrian Lundell <adrian.lundell@arm.com>
jirioc
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Dec 19, 2025
Currently only support for NHWC memory format. Adds weights-per-tensor quantization as default quantization. Generalizes the CortexMPassManager to work with any pass with exported_program as init arg to support using both XNNPackPasses and ArmPasses. Refactors the QuantizedLinearFusionPass to become a more general CovertToCortexMPass for replacing Aten ops with corresponding Cortex-M ops. Signed-off-by: Adrian Lundell <adrian.lundell@arm.com>
jirioc
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Dec 19, 2025
quck-fix after pytorch#15896 cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai Signed-off-by: Adrian Lundell <adrian.lundell@arm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently only support for NHWC memory format.
Adds weights-per-tensor quantization as default quantization.
Generalizes the CortexMPassManager to work with any pass with exported_program as init arg to support using both XNNPackPasses and ArmPasses.
Refactors the QuantizedLinearFusionPass to become a more general CovertToCortexMPass for replacing Aten ops with corresponding Cortex-M ops.
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai