Move user-defined passes after SpecPropPass#15932
Merged
meta-codesync[bot] merged 1 commit intopytorch:mainfrom Nov 22, 2025
Merged
Move user-defined passes after SpecPropPass#15932meta-codesync[bot] merged 1 commit intopytorch:mainfrom
meta-codesync[bot] merged 1 commit intopytorch:mainfrom
Conversation
lucylq
requested review from
JacobSzwejbka,
jackzhxng,
larryliu0820 and
mergennachin
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15932
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
lucylq
force-pushed
the
export-D87576772
branch
from
dee69c9 to
bd92f7a
Compare
Contributor
This PR needs a
|
larryliu0820
approved these changes
Nov 21, 2025
JacobSzwejbka
approved these changes
Nov 21, 2025
Contributor
JacobSzwejbka
left a comment
JacobSzwejbka
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Nov 21, 2025
Summary: 1. Use `ExecutorchBackendConfig` instead of inserting the pass. 2. Move SpecPropPass after user-defined passes. It was originally swapped here: D80840528. cc ethansfng, who has a pass that should run before SpecPropPass Reviewed By: JacobSzwejbka, larryliu0820 Differential Revision: D87576772
lucylq
force-pushed
the
export-D87576772
branch
from
bd92f7a to
6fd9ac3
Compare
Summary: 1. Use `ExecutorchBackendConfig` instead of inserting the pass. 2. Move SpecPropPass after user-defined passes. It was originally swapped here: D80840528. cc ethansfng, who has a pass that should run before SpecPropPass Reviewed By: JacobSzwejbka, larryliu0820 Differential Revision: D87576772
lucylq
force-pushed
the
export-D87576772
branch
from
6fd9ac3 to
3f1632c
Compare
jirioc
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Dec 19, 2025
Differential Revision: D87576772 Pull Request resolved: pytorch#15932
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
ExecutorchBackendConfiginstead of inserting the pass.Differential Revision: D87576772