Skip to content

Remove download progress reporting#15946

Merged
cccclai merged 2 commits intomainfrom
cccclai-patch-9
Nov 21, 2025
Merged

Remove download progress reporting#15946
cccclai merged 2 commits intomainfrom
cccclai-patch-9

Conversation

@cccclai
Copy link
Contributor

@cccclai cccclai commented Nov 21, 2025

It's not compatible with #15933 which cause 2^70+ byte counters like

Downloaded: 839890544179019776 / 1354151797 bytes (62023367397.93%)
Downloaded: 841813590016000000 / 1354151797 bytes (62165378496.04%)

@cccclai
Remove download progress reporting
ed5ca40 
It's not compatible with #15933 which cause 2^70+ byte counters like
```
Downloaded: 839890544179019776 / 1354151797 bytes (62023367397.93%)
Downloaded: 841813590016000000 / 1354151797 bytes (62165378496.04%)
```
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 21, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15946

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 103 Pending

As of commit d4b42d9 with merge base 17744b7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 21, 2025
@github-actions
Copy link

github-actions bot commented Nov 21, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@cccclai
Remove content-length header handling
d4b42d9 
Remove content-length header retrieval for download.
@cccclai cccclai merged commit 0f3d1b2 into main Nov 21, 2025
130 of 131 checks passed
@cccclai cccclai deleted the cccclai-patch-9 branch November 21, 2025 20:28
jirioc pushed a commit to nxp-upstream/executorch that referenced this pull request Dec 19, 2025
@cccclai @jirioc
Remove download progress reporting (pytorch#15946)
1730e63 
It's not compatible with
pytorch#15933 which cause 2^70+ byte
counters like
```
Downloaded: 839890544179019776 / 1354151797 bytes (62023367397.93%)
Downloaded: 841813590016000000 / 1354151797 bytes (62165378496.04%)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larryliu0820 larryliu0820 larryliu0820 approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cccclai @larryliu0820