Autoglob: don't expose mode labels#18069
Conversation
Summary: I've migrated the codebase to stop using these. Reviewed By: d16r Differential Revision: D95810888
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18069
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 129 PendingAs of commit 405b9c7 with merge base 286ccef ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@manuelcandales has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95810888. |
There was a problem hiding this comment.
Pull request overview
Removes unused EXPORT_UNLESS_INTERNAL imports from Apple BUCK targets, aligning with the migration away from exposing autoglob mode symbols in build files.
Changes:
- Dropped the
autoglob.bzlload ofEXPORT_UNLESS_INTERNALfromextension/apple/BUCK. - Dropped the same unused load from
extension/llm/apple/BUCK.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| extension/llm/apple/BUCK | Removes an unused EXPORT_UNLESS_INTERNAL load. |
| extension/apple/BUCK | Removes an unused EXPORT_UNLESS_INTERNAL load. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This PR needs a
|
Summary: I've migrated the codebase to stop using these.
Reviewed By: d16r
Differential Revision: D95810888