Skip to content

Autoglob: don't expose mode labels#18069

Merged
manuelcandales merged 1 commit intopytorch:mainfrom
manuelcandales:export-D95810888
Mar 10, 2026
Merged

Autoglob: don't expose mode labels#18069
manuelcandales merged 1 commit intopytorch:mainfrom
manuelcandales:export-D95810888

Conversation

@manuelcandales
Copy link
Contributor

Summary: I've migrated the codebase to stop using these.

Reviewed By: d16r

Differential Revision: D95810888

Summary: I've migrated the codebase to stop using these.

Reviewed By: d16r

Differential Revision: D95810888
Copilot AI review requested due to automatic review settings March 10, 2026 19:52
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 10, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18069

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 129 Pending

As of commit 405b9c7 with merge base 286ccef (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 10, 2026
@meta-codesync
Copy link
Contributor

meta-codesync bot commented Mar 10, 2026

@manuelcandales has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95810888.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes unused EXPORT_UNLESS_INTERNAL imports from Apple BUCK targets, aligning with the migration away from exposing autoglob mode symbols in build files.

Changes:

  • Dropped the autoglob.bzl load of EXPORT_UNLESS_INTERNAL from extension/apple/BUCK.
  • Dropped the same unused load from extension/llm/apple/BUCK.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
extension/llm/apple/BUCK Removes an unused EXPORT_UNLESS_INTERNAL load.
extension/apple/BUCK Removes an unused EXPORT_UNLESS_INTERNAL load.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@manuelcandales manuelcandales merged commit c85bfe1 into pytorch:main Mar 10, 2026
161 of 173 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants