Revise memory monitor to align with Xcode metrics#3131
Closed
nausicaasnow wants to merge 1 commit intopytorch:mainfrom
Closed
Revise memory monitor to align with Xcode metrics#3131nausicaasnow wants to merge 1 commit intopytorch:mainfrom
nausicaasnow wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3131
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit 1d8f6fe with merge base 4c552d4 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56290391 |
Summary: Ref: https://forums.developer.apple.com/forums/thread/105088 *If you’re going to record a single number, this footprint value is a good one to use. I don’t think we guarantee that it’ll align with the Xcode memory gauge, but it’s much more useful value than all the older stuff (like resident_size)* Therefore revise it. Differential Revision: D56290391
nausicaasnow
force-pushed
the
export-D56290391
branch
from
e60dab8 to
1d8f6fe
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56290391 |
shoumikhin
approved these changes
May 9, 2024
Contributor
|
This pull request has been merged in cc2d3b5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Ref: https://forums.developer.apple.com/forums/thread/105088
If you’re going to record a single number, this footprint value is a good one to use. I don’t think we guarantee that it’ll align with the Xcode memory gauge, but it’s much more useful value than all the older stuff (like resident_size)
Therefore revise it.
Differential Revision: D56290391