make extract_delegate_segments=True by default#3405
Closed
davidlin54 wants to merge 1 commit intopytorch:mainfrom
Closed
make extract_delegate_segments=True by default#3405davidlin54 wants to merge 1 commit intopytorch:mainfrom
davidlin54 wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3405
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 7cf9f49 with merge base dd81fc7 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
davidlin54
force-pushed
the
export-D56712292
branch
5 times, most recently
from
309c6b1 to
cc9fdff
Compare
Contributor
|
@pytorchbot drci (please ignore this, I'm testing Dr.CI) |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56712292 |
davidlin54
force-pushed
the
export-D56712292
branch
from
cc9fdff to
84da629
Compare
dbort
approved these changes
May 7, 2024
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56712292 |
davidlin54
force-pushed
the
export-D56712292
branch
from
84da629 to
03fe0d3
Compare
davidlin54
pushed a commit
to davidlin54/executorch
that referenced
this pull request
May 8, 2024
Summary: Pull Request resolved: pytorch#3405 updated all existing callsites to use the previous default value of False. when extract_delegate_segments is set to False (previous behavior), the backend blob data is part of the flatbuffer serialized program. this leads to higher memory consumption, as backends may not need the input blob post initialization, but cannot free the memory as it's part of the flatbuffer. when extract_delegate_segments is set to True, the backend blob data is extracted into separate segments. this way, each backend can choose to free the memory after initialization if it is no longer needed. this reduces peak memory consumption as a result. the con is that this leads to an increased program size due to internal padding between the flatbuffer program and the extracted segments Reviewed By: JacobSzwejbka, cccclai, dbort, zonglinpengmeta Differential Revision: D56712292
davidlin54
force-pushed
the
export-D56712292
branch
from
03fe0d3 to
cd82551
Compare
davidlin54
pushed a commit
to davidlin54/executorch
that referenced
this pull request
May 9, 2024
Summary: updated all existing callsites to use the previous default value of False. when extract_delegate_segments is set to False (previous behavior), the backend blob data is part of the flatbuffer serialized program. this leads to higher memory consumption, as backends may not need the input blob post initialization, but cannot free the memory as it's part of the flatbuffer. when extract_delegate_segments is set to True, the backend blob data is extracted into separate segments. this way, each backend can choose to free the memory after initialization if it is no longer needed. this reduces peak memory consumption as a result. the con is that this leads to an increased program size due to internal padding between the flatbuffer program and the extracted segments Reviewed By: JacobSzwejbka, cccclai, dbort, zonglinpengmeta Differential Revision: D56712292
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56712292 |
Summary: updated all existing callsites to use the previous default value of False. when extract_delegate_segments is set to False (previous behavior), the backend blob data is part of the flatbuffer serialized program. this leads to higher memory consumption, as backends may not need the input blob post initialization, but cannot free the memory as it's part of the flatbuffer. when extract_delegate_segments is set to True, the backend blob data is extracted into separate segments. this way, each backend can choose to free the memory after initialization if it is no longer needed. this reduces peak memory consumption as a result. the con is that this leads to an increased program size due to internal padding between the flatbuffer program and the extracted segments Reviewed By: JacobSzwejbka, cccclai, dbort, zonglinpengmeta Differential Revision: D56712292
davidlin54
force-pushed
the
export-D56712292
branch
from
cd82551 to
7cf9f49
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56712292 |
Contributor
|
This pull request has been merged in cc11541. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: updated all existing callsites to use the previous default value of False
Differential Revision: D56712292