[ET-VK][EZ] Rename Allocator.* as vma_api.*#3552
Closed
junpi3 wants to merge 1 commit intogh/jorgep31415/56/basefrom
Closed
[ET-VK][EZ] Rename Allocator.* as vma_api.*#3552junpi3 wants to merge 1 commit intogh/jorgep31415/56/basefrom
Allocator.* as vma_api.*#3552junpi3 wants to merge 1 commit intogh/jorgep31415/56/basefrom
Conversation
We currently use `vk_api.h` for inclusion of third-party `vulkan-headers`. To adhere to the same style, we rename as `vma_api.h` for inclusion of third-party `VulkanMemoryAllocator`. (This also opens the door to renaming our wrapper `MemoryAllocator` to `Allocator` in the next change.) Differential Revision: [D57126895](https://our.internmc.facebook.com/intern/diff/D57126895/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3552
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 98e71a2 with merge base 251aa74 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57126895 |
This was referenced May 8, 2024
SS-JIA
approved these changes
May 8, 2024
Contributor
|
This pull request has been merged in 2d68bd3. |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
We currently use `vk_api.h` for inclusion of third-party `vulkan-headers`. To adhere to the same style, we rename as `vma_api.h` for inclusion of third-party `VulkanMemoryAllocator`. (This also opens the door to renaming our wrapper `MemoryAllocator` to `Allocator` in the next change.) Differential Revision: [D57126895](https://our.internmc.facebook.com/intern/diff/D57126895/) ghstack-source-id: 225636265 Pull Request resolved: pytorch/executorch#3552
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
api::prefix withinnamespace api#3554Resource.hinto multiple files withinresource/#3553Allocator.*asvma_api.*#3552We currently use
vk_api.hfor inclusion of third-partyvulkan-headers.To adhere to the same style, we rename as
vma_api.hfor inclusion of third-partyVulkanMemoryAllocator. (This also opens the door to renaming our wrapperMemoryAllocatortoAllocatorin the next change.)Differential Revision: D57126895