Add target_link_options_shared_lib to coremldelegate build#3556
Closed
swolchok wants to merge 1 commit intopytorch:mainfrom
Closed
Add target_link_options_shared_lib to coremldelegate build#3556swolchok wants to merge 1 commit intopytorch:mainfrom
swolchok wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3556
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 2dfc737 with merge base dd81fc7 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kimishpatel
approved these changes
May 8, 2024
Summary: Backends use a static initializer to register themselves. We have an established solution to forcing the Apple linker to load the object files containing said initializer, so let's use it for CoreML. Test Plan: Attempt to load a CoreML PTE from Python no longer fails with error about the backend not being registered
Contributor
|
@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
swolchok
force-pushed
the
unbreak-coreml-from-python
branch
from
9afb921 to
2dfc737
Compare
Contributor
|
@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Backends use a static initializer to register themselves. We have an established solution to forcing the Apple linker to load the object files containing said initializer, so let's use it for CoreML.
Test Plan: Attempt to load a CoreML PTE from Python no longer fails with error about the backend not being registered