Reuse the existing clone of the ios toolchain for Core ML.#3575
Closed
shoumikhin wants to merge 1 commit intopytorch:mainfrom
shoumikhin:export-D57225246
Closed
Reuse the existing clone of the ios toolchain for Core ML.#3575shoumikhin wants to merge 1 commit intopytorch:mainfrom shoumikhin:export-D57225246
shoumikhin wants to merge 1 commit intopytorch:mainfrom
shoumikhin:export-D57225246
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3575
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit 47ccfd8 with merge base 87d828a ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57225246 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57225246 |
Contributor
|
@cymbalrush - please take a look. we recently added dependency to ios-toolchain in the third-party directory. This allows us to just reuse that instead. |
Contributor
|
Looks good, thank you! |
cymbalrush
approved these changes
May 13, 2024
Summary: . Reviewed By: mergennachin Differential Revision: D57225246
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57225246 |
Contributor
|
This pull request has been merged in 4b5e434. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: .
Differential Revision: D57225246