don't partition max pool with ceil mode#3578
Closed
mcr229 wants to merge 1 commit intopytorch:mainfrom
Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3578
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3bc9fdd with merge base b93b7ae ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57228128 |
Summary: XNNPACK doesn't support max pooling with ceil mode, so we should not be partitioning these nodes where ceil mode is True Resolving this issue: pytorch#3567 Differential Revision: D57228128
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57228128 |
mergennachin
approved these changes
May 10, 2024
Contributor
|
This pull request has been merged in 87d828a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
XNNPACK doesn't support max pooling with ceil mode, so we should not be partitioning these nodes where ceil mode is True
Resolving this issue:
#3567
Differential Revision: D57228128