Fix memory.view insertion except for output nodes#3602
Closed
dulinriley wants to merge 1 commit intopytorch:mainfrom
Closed
Fix memory.view insertion except for output nodes#3602dulinriley wants to merge 1 commit intopytorch:mainfrom
dulinriley wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3602
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 81ab3fb with merge base c69861d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57299853 |
metascroy
approved these changes
May 14, 2024
dulinriley
added a commit
to dulinriley/executorch
that referenced
this pull request
May 14, 2024
Summary: The previous implementation of ignoring `view_copy` on outputs was incorrect in that it only checked `node.next` instead of all users of the node. `node.next` just selects the next node in topological order, which may or may not be the output if there is more than one output. In the case of more than one output, the next node may not be related at all! Check if any of the users of the node are an output instead. Reviewed By: metascroy, mcremon-meta Differential Revision: D57299853
dulinriley
force-pushed
the
export-D57299853
branch
from
a19c687 to
acfe395
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57299853 |
Summary: The previous implementation of ignoring `view_copy` on outputs was incorrect in that it only checked `node.next` instead of all users of the node. `node.next` just selects the next node in topological order, which may or may not be the output if there is more than one output. In the case of more than one output, the next node may not be related at all! Check if any of the users of the node are an output instead. Reviewed By: metascroy, mcremon-meta Differential Revision: D57299853
dulinriley
force-pushed
the
export-D57299853
branch
from
acfe395 to
81ab3fb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57299853 |
dulinriley
added a commit
to dulinriley/executorch
that referenced
this pull request
May 14, 2024
Summary: The previous implementation of ignoring `view_copy` on outputs was incorrect in that it only checked `node.next` instead of all users of the node. `node.next` just selects the next node in topological order, which may or may not be the output if there is more than one output. In the case of more than one output, the next node may not be related at all! Check if any of the users of the node are an output instead. Reviewed By: metascroy, mcremon-meta Differential Revision: D57299853
dulinriley
added a commit
to dulinriley/executorch
that referenced
this pull request
May 14, 2024
Summary: The previous implementation of ignoring `view_copy` on outputs was incorrect in that it only checked `node.next` instead of all users of the node. `node.next` just selects the next node in topological order, which may or may not be the output if there is more than one output. In the case of more than one output, the next node may not be related at all! Check if any of the users of the node are an output instead. Reviewed By: metascroy, mcremon-meta Differential Revision: D57299853
Contributor
|
This pull request has been merged in b64182d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The previous implementation of ignoring
view_copyon outputs was incorrectin that it only checked
node.nextinstead of all users of the node.node.nextjust selects the next node in topological order, which may ormay not be the output if there is more than one output. In the case of more
than one output, the next node may not be related at all!
Check if any of the users of the node are an output instead.
Reviewed By: metascroy, mcremon-meta
Differential Revision: D57299853