Skip to content

[executorch] Work around an old GCC bug in memory_manager.h #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dbort wants to merge 1 commit into from
Closed

[executorch] Work around an old GCC bug in memory_manager.h #529

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion runtime/executor/memory_manager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,11 @@ class MemoryManager final {
* TODO(T162089316): Remove this once all users migrate to the new ctor.
*/
__ET_DEPRECATED MemoryManager(
__ET_UNUSED MemoryAllocator* constant_allocator,
// We would normally use __ET_UNUSED here, but GCC older than 9.3 has a
// bug that triggers a syntax error when using [[maybe_unused]] on the
// first parameter of a constructor:
// https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81429
__attribute__((unused)) MemoryAllocator* constant_allocator,
HierarchicalAllocator* non_constant_allocator,
MemoryAllocator* runtime_allocator,
MemoryAllocator* kernel_temporary_allocator)
Expand Down