Qualcomm AI Engine Direct - Fixed layer norm quantization annotation for 16bit#5927
Closed
shewu-quic wants to merge 1 commit intopytorch:mainfrom
Closed
Conversation
Collaborator
shewu-quic
commented
Oct 7, 2024
shewu-quic
commented
- Fixed quantization annotation for layer norm in 16bit.
- Add a unit test for 16a4w layer norm.
…for 16bit - Fixed quantization annotation for layer norm in 16bit. - Add a unit test for 16a4w layer norm.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5927
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 82798df with merge base c06a708 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
cccclai
approved these changes
Oct 7, 2024
Contributor
cccclai
left a comment
cccclai
left a comment
There was a problem hiding this comment.
Thanks for sending the fix and adding the unit test.
Contributor
|
@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.