[TOSA] Replace Linear lowering of using Matmul with FullyConnected

[Jerry-Ge]

No description provided.

[netlify]

✅ Deploy Preview for resplendent-gnome-14e531 ready!

Name	Link
🔨 Latest commit	18dac76
🔍 Latest deploy log	https://app.netlify.com/sites/resplendent-gnome-14e531/deploys/652758759cbeac0008a9e8d1
😎 Deploy Preview	https://deploy-preview-616--resplendent-gnome-14e531.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[cccclai]

lgtm, let's try to add tests in case there are breakages. Looks like there are many if else

[digantdesai]

LGTM. Left some comments, OK for now. Add TODOs as required.
But please add torch.nn.Linear tests with >2 rank.

i.e. copy simple_linear test into not_so_simple_linear with

(torch.ones(100, 20),), -> (torch.ones(5, 10, 100, 20),),

[Jerry-Ge]

there're some large number of test model failures. Don't seem related? (I can't see the errors inside)

[cccclai]

Looks good. Let's restructure and add more tests after MVP. I'm getting lost in the if-else....

[Jerry-Ge]

Looks good. Let's restructure and add more tests after MVP. I'm getting lost in the if-else....

I agree. It's a pain 😓

[digantdesai]

lgtm, let mw know when you are ready

[facebook-github-bot]

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[Jerry-Ge]

lgtm, let mw know when you are ready

tks, i'm ready. but not sure if this will have merge conflicts with #659 and #615

[facebook-github-bot]

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.