Closed
Conversation
Contributor
Author
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6555
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 11a650e with merge base 2c32bf3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
@helunwencser has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have been using a pretty old
lm_evalversion. This is blocking us from upgrading other libraries liketransformersand blocking some others work. For example, #6489.In newer versions
lm_eval,pretrainedModelbecomes a required parameter. In 0.4.2, it defaults togpt2if not provided. This PR upgrades ourlm_evalversion to the latest version 0.4.5 and setpretrainedModelto its original default valuegpt2.Test Plan:

Run eval before and after this PR. Make sure the perplexity number stays around the same.
Differential Revision: D65162734