Move shim/xplat to shim_et/xplat, try 2#8607
Closed
swolchok wants to merge 2 commits intogh/swolchok/275/basefrom
Closed
Move shim/xplat to shim_et/xplat, try 2#8607swolchok wants to merge 2 commits intogh/swolchok/275/basefrom
swolchok wants to merge 2 commits intogh/swolchok/275/basefrom
Conversation
Looks like in order to get this right, we're going to have to update some internal configuration and originate this PR from internal repo. Supersedes #8583 / D69882927. Differential Revision: [D69955361](https://our.internmc.facebook.com/intern/diff/D69955361/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8607
Note: Links to docs will display an error until the docs builds have been completed. ❌ 36 New FailuresAs of commit c4305b2 with merge base abe8834 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69955361 |
swolchok
pushed a commit
that referenced
this pull request
Feb 21, 2025
Looks like in order to get this right, we're going to have to update some internal configuration and originate this PR from internal repo. Supersedes #8583 / D69882927. Differential Revision: [D69955361](https://our.internmc.facebook.com/intern/diff/D69955361/) ghstack-source-id: 267533770 Pull Request resolved: #8607
larryliu0820
approved these changes
Feb 21, 2025
Contributor
larryliu0820
left a comment
There was a problem hiding this comment.
Yeah I guess landing this without shipit will break Android build
Looks like in order to get this right, we're going to have to update some internal configuration and originate this PR from internal repo. Supersedes #8583 / D69882927. Differential Revision: [D69955361](https://our.internmc.facebook.com/intern/diff/D69955361/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Feb 24, 2025
Pull Request resolved: #8607 Looks like in order to get this right, we're going to have to update some internal configuration and originate this PR from internal repo. Supersedes #8583 / D69882927. Differential Revision: [D69955361](https://our.internmc.facebook.com/intern/diff/D69955361/) ghstack-source-id: 268021896
Contributor
Author
|
superseded by #8647 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Looks like in order to get this right, we're going to have to update some internal configuration and originate this PR from internal repo. Supersedes #8583 / D69882927.
Differential Revision: D69955361