Skip to content

Fix num_iters > 5 Shiftpointer issue#9150

Merged
facebook-github-bot merged 1 commit intopytorch:mainfrom
billmguo:export-D70974749
Mar 13, 2025
Merged

Fix num_iters > 5 Shiftpointer issue#9150
facebook-github-bot merged 1 commit intopytorch:mainfrom
billmguo:export-D70974749

Conversation

@billmguo
Copy link
Contributor

@billmguo billmguo commented Mar 11, 2025

Summary: in the original implementation when num_iters > 5 it will crash during exit

Differential Revision: D70974749

@billmguo billmguo requested a review from cccclai as a code owner March 11, 2025 18:49
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9150

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 4 Pending

As of commit 972e0b0 with merge base ebea003 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 11, 2025
@cccclai
Copy link
Contributor

cccclai commented Mar 11, 2025

Can you explain what is the issue?

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 11, 2025

This pull request was exported from Phabricator. Differential Revision: D70974749

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 11, 2025

This pull request was exported from Phabricator. Differential Revision: D70974749

@billmguo
Copy link
Contributor Author

billmguo commented Mar 11, 2025

@pytorchbot label "topic: not user facing"

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 11, 2025

This pull request was exported from Phabricator. Differential Revision: D70974749

billmguo added a commit to billmguo/executorch that referenced this pull request Mar 11, 2025
@billmguo @facebook-github-bot
Fix num_iters > 5 Shiftpointer issue (pytorch#9150)
b163d44 
Summary:
Pull Request resolved: pytorch#9150

in the original implementation when num_iters > 5 it will crash during exit

Differential Revision: D70974749
@billmguo
Copy link
Contributor Author

billmguo commented Mar 12, 2025

03-11 09:52:35.461 21905 21905 F DEBUG : #00 pc 000000000005b730 /apex/com.android.runtime/lib64/bionic/libc.so (abort+168) (BuildId: edc1b601d9f8344c1eccd3d77a458f65)
03-11 09:52:35.461 21905 21905 F DEBUG : #1 pc 0000000000048f20 /apex/com.android.runtime/lib64/bionic/libc.so (scudo::die()+12) (BuildId: edc1b601d9f8344c1eccd3d77a458f65)
03-11 09:52:35.461 21905 21905 F DEBUG : #2 pc 00000000000498a8 /apex/com.android.runtime/lib64/bionic/libc.so (scudo::ScopedErrorReport::~ScopedErrorReport()+36) (BuildId: edc1b601d9f8344c1eccd3d77a458f65)
03-11 09:52:35.461 21905 21905 F DEBUG : #3 pc 0000000000049b08 /apex/com.android.runtime/lib64/bionic/libc.so (scudo::reportHeaderCorruption(void*)+100) (BuildId: edc1b601d9f8344c1eccd3d77a458f65)
03-11 09:52:35.461 21905 21905 F DEBUG : #4 pc 000000000004b82c /apex/com.android.runtime/lib64/bionic/libc.so (scudo::Allocator<scudo::AndroidConfig, &(scudo_malloc_postinit)>::deallocate(void*, scudo::Chunk::Origin, unsigned long, unsigned long)+304) (BuildId: edc1b601d9f8344c1eccd3d77a458f65)
03-11 09:52:35.462 21905 21905 F DEBUG : #5 pc 000000000027d98c /data/local/tmp/qnn_test_runner
03-11 09:52:35.462 21905 21905 F DEBUG : #6 pc 00000000000d20e4 /data/local/tmp/qnn_test_runner
03-11 09:52:35.462 21905 21905 F DEBUG : #7 pc 00000000000d2094 /data/local/tmp/qnn_test_runner
03-11 09:52:35.462 21905 21905 F DEBUG : #8 pc 00000000000d2038 /data/local/tmp/qnn_test_runner
03-11 09:52:35.462 21905 21905 F DEBUG : #9 pc 0000000000108da4 /data/local/tmp/qnn_test_runner
03-11 09:52:35.462 21905 21905 F DEBUG : #10 pc 0000000000108c24 /data/local/tmp/qnn_test_runner
03-11 09:52:35.462 21905 21905 F DEBUG : #11 pc 0000000000108bb4 /data/local/tmp/qnn_test_runner
03-11 09:52:35.463 21905 21905 F DEBUG : #12 pc 0000000000108a24 /data/local/tmp/qnn_test_runner
03-11 09:52:35.463 21905 21905 F DEBUG : #13 pc 0000000000108990 /data/local/tmp/qnn_test_runner
03-11 09:52:35.463 21905 21905 F DEBUG : #14 pc 000000000010894c /data/local/tmp/qnn_test_runner
03-11 09:52:35.463 21905 21905 F DEBUG : #15 pc 00000000001088f8 /data/local/tmp/qnn_test_runner
03-11 09:52:35.463 21905 21905 F DEBUG : #16 pc 0000000000118870 /data/local/tmp/qnn_test_runner
03-11 09:52:35.464 21905 21905 F DEBUG : #17 pc 00000000000f6338 /data/local/tmp/qnn_test_runner
03-11 09:52:35.464 21905 21905 F DEBUG : #18 pc 00000000000f6398 /data/local/tmp/qnn_test_runner
03-11 09:52:35.464 21905 21905 F DEBUG : #19 pc 00000000001035e4 /data/local/tmp/qnn_test_runner
03-11 09:52:35.464 21905 21905 F DEBUG : #20 pc 000000000010360c /data/local/tmp/qnn_test_runner
03-11 09:52:35.464 21905 21905 F DEBUG : #21 pc 00000000000d3bd0 /data/local/tmp/qnn_test_runner
03-11 09:52:35.464 21905 21905 F DEBUG : #22 pc 00000000000d3b44 /data/local/tmp/qnn_test_runner
03-11 09:52:35.464 21905 21905 F DEBUG : #23 pc 00000000000d39fc /data/local/tmp/qnn_test_runner
03-11 09:52:35.464 21905 21905 F DEBUG : #24 pc 00000000000d0a38 /data/local/tmp/qnn_test_runner
03-11 09:52:35.464 21905 21905 F DEBUG : #25 pc 00000000000d0258 /data/local/tmp/qnn_test_runner
03-11 09:52:35.465 21905 21905 F DEBUG : #26 pc 0000000000053e50 /apex/com.android.runtime/lib64/bionic/libc.so (__libc_init+108) (BuildId: edc1b601d9f8344c1eccd3d77a458f65)

haowhsu-quic
haowhsu-quic approved these changes Mar 13, 2025
View reviewed changes
Copy link
Collaborator

@haowhsu-quic haowhsu-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

cccclai
cccclai approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of QC's team review

@billmguo @facebook-github-bot
Fix num_iters > 5 Shiftpointer issue (pytorch#9150)
972e0b0 
Summary:

in the original implementation when num_iters > 5 it will crash during exit

Reviewed By: cccclai

Differential Revision: D70974749
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 13, 2025

This pull request was exported from Phabricator. Differential Revision: D70974749

@facebook-github-bot facebook-github-bot merged commit e3de804 into pytorch:main Mar 13, 2025
48 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cccclai cccclai cccclai approved these changes

@chunit-quic chunit-quic Awaiting requested review from chunit-quic

@shewu-quic shewu-quic Awaiting requested review from shewu-quic

@winskuo-quic winskuo-quic Awaiting requested review from winskuo-quic

+1 more reviewer

@haowhsu-quic haowhsu-quic haowhsu-quic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@billmguo @cccclai @facebook-github-bot @haowhsu-quic