Add mixed dtype check for XNNPACK partitioner#9612
Merged
mcr229 merged 5 commits intopytorch:mainfrom Mar 27, 2025
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9612
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bc7dba2 with merge base 879b94f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
keyprocedure
changed the title
Contributor
Author
|
@pytorchbot label "topic: not user facing" |
Contributor
|
do you mind running python -m unittest backends/xnnpack/test/ops/*.py just to make sure there aren't any unintended consequences |
mcr229
reviewed
Mar 26, 2025
Contributor
|
hmm seems like: is passing which means all those tests are passing. Let's just try and fix the linter issues. |
mcr229
reviewed
Mar 26, 2025
Contributor
|
will stamp and merge after all ci is run |
mcr229
approved these changes
Mar 27, 2025
Contributor
|
Thank you for your contribution! |
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
### Summary Fixes #9023 Prevents the partitioner from handling ops with mixed dtypes. ### Test plan Unable to directly test due to auto-casting of dtypes and existing dtype checks in verifier.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9023
Prevents the partitioner from handling ops with mixed dtypes.
Test plan
Unable to directly test due to auto-casting of dtypes and existing dtype checks in verifier.py.