Closed
Conversation
Lucaskabela
approved these changes
Apr 13, 2026
fegin
reviewed
Apr 13, 2026
|
|
||
| ### 2. Investigate | ||
| - Read relevant TorchTitan source code in `{workspace}/jobs/{job_id}/torchtitan/`. | ||
| - Key source locations: `torchtitan/models/`, `torchtitan/parallelisms/`, `torchtitan/train.py`, `torchtitan/config_manager.py` |
Contributor
There was a problem hiding this comment.
torchtitan/parallelisms/ and torchtitan/config_manager.py do not exist. Do you mean torchtitan/distributed/, torchtitan/config/job_config.py?
tianyu-l
requested changes
Apr 13, 2026
Contributor
tianyu-l
left a comment
There was a problem hiding this comment.
discussed offline:
- since
ptqis still new, as torchtitan maintainer I prefer this not to be exposed to OSS publicly yet - on
ptqside @drisspg seems happy with torchtitan specifics added toptqrepo, so technically this is unblocked - more than happy to revisit later
Member
Author
|
Landed as a hardcoded repo in drisspg/pt_job_queue#9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed needed for: drisspg/pt_job_queue#9
There's 2 usage modes:
ptq)ptqcommands withuv run)Quick Start: Using ptq with TorchTitan (Remote on ODC)
Prerequisites
1. Set up workspace
Testing plan in upstream PR: drisspg/pt_job_queue#9.
