Clean up usage of the deprecated mode parameter.#9170
Clean up usage of the deprecated mode parameter.#9170drivanov wants to merge 6 commits intopytorch:mainfrom
mode parameter.#9170Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9170
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 53e0954 with merge base 97920a5 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @drivanov! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Hi @NicolasHug, I tested with |
While testing the latest version of the NVIDIA PYG container, we encountered the following issue:
From what I can see here, the
fromarrayfunction expects themodeparameter to beNoneonly.Notes:
It used to be:
and is now:
As a result, we should remove the usage of the
modeparameter in line 254 oftorchvision/utils.py: