Fix img padding in Chrome #55
Conversation
Krejdom
commented
Mar 7, 2017
Krejdom
commented
- Remove the gray padding under the image in Chrome.
- Put hard spaces after "a" and "i".
naucse/templates/index.html
Outdated
| <p class="responsive-text card-text center">Nauč se Python, staň se superhrdinou nebo superhrdinkou a zachraň svět.<br> | ||
| Python je moderní programovací jazyk. Je univerzální – pohání weby i rakety. | ||
| Dobře se čte a dá se velice rychle naučit.</p> | ||
| <p class="responsive-text card-text center">Nauč se Python, staň se superhrdinou nebo superhrdinkou a zachraň svět.<br> |
There was a problem hiding this comment.
Please use Unicode non-breaking spaces to keep the source readable.
There was a problem hiding this comment.
It's not possible in html. :(
There was a problem hiding this comment.
It sure is. But I'd recommend to keep visible entities, because in many editors this is no different from normal space and it's confusing as hell for a coder.
Other way to keep cleaner text would be a postprocessing that automatically replaces spaces. Kind of like Texy! does.
There was a problem hiding this comment.
And typographicaly it's ok to break line after „a“ and „i“. But I don’t like it either.
There was a problem hiding this comment.
I disagree about . The reasons make more sense for long text, but I think this should be consistent.
Naucse should ultimately be a site for collaboratively written text. And just like a book has an author and an editor, the people writing (and reading!) the text shouldn't need to concern themselves with typography if they don't want to. If you don't have your editor set up to highlight whitespace, you probably don't care, and that's okay. But having everywhere makes the text is unreadable, and I do want people to be able read the source – it makes little contributions easier.
That all could be „solved“ by an automatic Texy!-like system, but I think keeping things explicit is better. What I'd like to set up, eventually, is a linter – something that flags mistakes on pull requests, so either the author or the person merging it can fix these little mistakes. I don't want a typographical Autocomplete.
About the a and i: this is not a paragraph of running text. I wouldn't mind putting non-breaking spaces even between long words if that would make it look better as a whole.
There was a problem hiding this comment.
@encukou That makes sense. This context is different.
About a and i, sure, I do that too with different words where it's not mandatory. I just wanted to point out it isn't (without asking what the reason was, shame on me).
[Ostrava] Feedback for lesson about inheritance
* Fix: title attribute on img tag (pyvec#49) * Remove course definition * Drobné úpravy Reformulace, překlepy, ... Co-authored-by: Jan Pipek <jan.pipek@gmail.com> Co-authored-by: Lumír 'Frenzy' Balhar <frenzy.madness@gmail.com>
3 participants
