Skip to content

Update use of diffpy.structure to silence warnings from 3.4.0 #643

@hakonanes

Description

@hakonanes

The diffpy.structure maintainers renamed a lot of methods in yesterday's 3.4.0: https://github.com/diffpy/diffpy.structure/releases/tag/3.4.0. We should go through and call all the new methods instead of the old ones.

I suggest we add a private helper module for handling diffpy.structure where we import the correct functions based on the version. I've done this for RosettaSciIO imports in kikuchipy: https://github.com/pyxem/kikuchipy/blob/develop/src/kikuchipy/_utils/rosettasciio_utils.py.

Metadata

Metadata

Assignees

No one assigned

    Labels

    deprecationDeprecated functionality and/or namesdevPackage maintenance

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions