CI: Add pre-commit CI#472
Merged
Merged
Conversation
Member
Author
|
@pc494 Can you add access to orix from https://pre-commit.ci |
This was referenced Mar 26, 2024
Closed
Member
|
pre-commit.ci autofix |
Member
|
at a guess this failure is due to the style changes between 2023 and 2024. @CSSFrancis could you run locally so this comes up green as I imagine we need this merged before we can autofix. |
Member
Author
|
@pc494 Yep you are correct. The joys of running |
Member
Author
|
@pc494 This should be fixed now and we can auto fix now which is nice. |
pc494
approved these changes
Mar 26, 2024
| repos: | ||
| - repo: https://github.com/psf/black | ||
| rev: 23.1.0 | ||
| rev: 24.3.0 |
Member
|
I am going to merge this on the condition that @CSSFrancis remembers to add himself to the Zenodo when we get to #460. This PR closes #463. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI: Add pre-commit CI
This adds lines to pre-commit for CI to run isort and black from a comment to a PR.
For reviewers
__init__.py.section in
CHANGELOG.rst.__credits__inorix/__init__.pyand in.zenodo.json.