Add missing point groups#647
Open
argerlt wants to merge 6 commits into
Open
Conversation
7 tasks
Collaborator
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
…/orix into Add_missing_point_groups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking out this part of #563 into it's own PR.
Description of the change
This adds all the missing default point group symmetries to the symmetry module, and creates a dictionary of important sets of point groups. This also means replacing
symmetry._groupsandsymmetry._proper_groupswith (depending on the application)symmetry._symm_lists['permutations'],symmetry._symm_lists['groups'], orsymmetry._symm_lists['proper_groups']where appropriate. These are all private changes, and shouldn't affect any public-facing performance.At one point last year a variation of this done in #563, and the suggestion was made that instead of dictionaries of lists of groups, we should just have a
PointGroupsclass. I still agree with that idea, this seperate sub-issue is just about adding the private variables with the correct lists and names, so that #563 doesn't need to be a 1800+ line PR.Progress of the PR
Minimal example of the bug fix or new feature
For reviewers
__init__.py.section in
CHANGELOG.rst.__credits__inorix/__init__.pyand in.zenodo.json.