Solve version discrepancy in release#142
Merged
TheGupta2012 merged 4 commits intomainfrom Feb 20, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
bf479f4 to
8bbc663
Compare
setuptools_scm and use _version.py for version
ryanhill1
previously approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
v0.2.0resulted in a version discrepancy -It is unclear why this happened but one change might be the
pipversion used bycibuildwheelin GitHub runner. The releasev0.2.0usedpip==25.0.1whereasv0.1.0usedpip==24.3.1on the runners.Summary of changes
To get reproducible results, have added
_version.pyin the repo and used thedynamicattribute in.tomlto get the version (as in the qBraid SDK).This eliminates the dependency on
setuptools_scm0.2.1.dev0+g0fd2956.d20250214matches the [4th option of Default Versioning Scheme in the docs] (https://setuptools-scm.readthedocs.io/en/latest/usage/)0fd2956was tagged withv0.2.0, EOL changes might have happened due to the newly added.gitattributesfileSummary of changes
git resetin the pre-build script to ensure that no uncommitted changes are passed into the build processno-guess-devvalue forversion_schemeto ensure that nodevsuffixes are present in the version