Add check for duplicate qubits post gate broadcast#155
Merged
TheGupta2012 merged 2 commits intomainfrom Mar 3, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #75
Summary of changes
Introduced the static methods
extract_duplicate_qubitandverify_gate_qubitsinQasm3Analyzerto detect and raise errors for duplicate qubits in quantum gates.Removed the duplicate bit check logic from the
_get_op_bitsmethod insrc/pyqasm/visitor.py, as this validation is now handled by the newverify_gate_qubitsmethod. [1] [2]Updated the
_visit_basic_gate_operationandgate_functionmethods insrc/pyqasm/visitor.pyto use the newverify_gate_qubitsmethod for checking duplicate qubits. [1] [2]Added a new test case for duplicate qubits in
tests/qasm3/resources/gates.pyto ensure the new validation logic works as expected.