Remove deepcopy in _visit_generic_gate_operation#180
Merged
TheGupta2012 merged 3 commits intomainfrom May 1, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Member
Author
|
@bachase post this change can you test the |
|
@TheGupta2012 a nice improvement! The call stack starting from https://github.com/qBraid/qBraid/blob/7ac709340740e6703acb81cbee586112573d703b/qbraid/transpiler/conversions/qasm2/qasm2_to_cirq.py#L50 went from 13.67 seconds to 3.16 seconds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference : #962 | qBraid
Summary of changes
The change changes the deep copy of the
operationandctrlsvariables into a shallow copy, likely to improve performance and reduce unnecessary memory usage.