Added duration, stretch, delay and box type support#231
Merged
TheGupta2012 merged 6 commits intoqBraid:mainfrom Jul 28, 2025
Merged
Added duration, stretch, delay and box type support#231TheGupta2012 merged 6 commits intoqBraid:mainfrom
duration, stretch, delay and box type support#231TheGupta2012 merged 6 commits intoqBraid:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
vinayswamik
changed the title
Duration type supportduration, stretch, delay type support
TheGupta2012
requested changes
Jul 17, 2025
Member
TheGupta2012
left a comment
TheGupta2012
left a comment
There was a problem hiding this comment.
Changes look good overall @vinayswamik ! Gave some suggestions about the refactoring of code.
vinayswamik
changed the title
duration, stretch, delay type supportduration, stretch, delay and box type support
vinayswamik
force-pushed
the
feature/circuit-timing-operations
branch
from
3583e27 to
30e03f2
Compare
- code restructured - updated test cases - code rebased
Member
|
Gave some minor comments @vinayswamik , it should be good to merge post that. Also, can you add a small working example in the |
ryanhill1
requested changes
Jul 22, 2025
Member
ryanhill1
left a comment
ryanhill1
left a comment
There was a problem hiding this comment.
Update Supported Operations list
…le is not constant when used in a local scope.
ryanhill1
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Added duration, stretch, delay and box support
time_unitattribute to theVariableclass to associate duration variables with their time units.loadsfunction to acceptdevice_cycle_timefor better handling of duration calculations.QasmVisitor.StretchandDelayInstructionoperations.Closes #90
Closes #91
Closes #92
Closes #93
Closes #94