Skip to content

Fixes #216#233

Merged
TheGupta2012 merged 10 commits intoqBraid:mainfrom
arunjmoorthy:issue216
Aug 5, 2025
Merged

Fixes #216#233
TheGupta2012 merged 10 commits intoqBraid:mainfrom
arunjmoorthy:issue216

Conversation

@arunjmoorthy
Copy link
Copy Markdown
Collaborator

@arunjmoorthy arunjmoorthy commented Jul 16, 2025

Fixes #216

Summary of changes

  • in base.py added user_operations to track history of gates
  • in base.py, added get_gate_counts to count all gates used
  • in base.py, added compare that compares QasmModule's and shows attributes
  • Added test_compare in tests/visualizations to check for proper output

Copy link
Copy Markdown
Member

@TheGupta2012 TheGupta2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arunjmoorthy for the work! The tabular format looks good, gave some comments about the requirements and code.

@TheGupta2012
Copy link
Copy Markdown
Member

TheGupta2012 commented Jul 17, 2025

Can you please fix the tests ( need to add tabulate as a testing dependency as well ) and add an entry to the CHANGELOG.md ?

@TheGupta2012
Copy link
Copy Markdown
Member

Hi @arunjmoorthy , thanks for the updates! Besides the one change that @ryanhill1 mentioned, I think the code looks good. Can you address that and resolve merge conflicts? Should be good to merge post that

@TheGupta2012
Copy link
Copy Markdown
Member

Hi @arunjmoorthy , changes lgtm. Can you fix the format for the PR before I can merge?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 24, 2025

Codecov Report

❌ Patch coverage is 95.71429% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pyqasm/modules/base.py 94.73% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@TheGupta2012 TheGupta2012 self-requested a review August 4, 2025 08:17
TheGupta2012
TheGupta2012 previously approved these changes Aug 4, 2025
Copy link
Copy Markdown
Member

@TheGupta2012 TheGupta2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

ryanhill1
ryanhill1 previously approved these changes Aug 4, 2025
@ryanhill1
Copy link
Copy Markdown
Member

On PR squash and merge make sure to change the commit name to something more descriptive

@TheGupta2012 TheGupta2012 dismissed stale reviews from ryanhill1 and themself via b7886f1 August 5, 2025 02:55
@TheGupta2012 TheGupta2012 merged commit c81a5dc into qBraid:main Aug 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Implement a .compare() method for QasmModule

4 participants