Conversation
TheGupta2012
left a comment
There was a problem hiding this comment.
Thanks @arunjmoorthy for the work! The tabular format looks good, gave some comments about the requirements and code.
|
Can you please fix the tests ( need to add |
|
Hi @arunjmoorthy , thanks for the updates! Besides the one change that @ryanhill1 mentioned, I think the code looks good. Can you address that and resolve merge conflicts? Should be good to merge post that |
|
Hi @arunjmoorthy , changes lgtm. Can you fix the format for the PR before I can merge? |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
On PR squash and merge make sure to change the commit name to something more descriptive |
Fixes #216
Summary of changes