Fixed: Duplicate qubits not detected in function call & Error in function call with aliased qubit#260
Merged
TheGupta2012 merged 5 commits intomainfrom Sep 4, 2025
Merged
Fixed: Duplicate qubits not detected in function call & Error in function call with aliased qubit#260TheGupta2012 merged 5 commits intomainfrom
TheGupta2012 merged 5 commits intomainfrom
Conversation
vinayswamik
requested review from
TheGupta2012
and removed request for
TheGupta2012
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…target qubit resolution and improving duplicate qubit validation for aliased arguments.
vinayswamik
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ocessor
Summary of changes
Enhance QASM validation by moving unique qubit check to subroutine processor
validate_unique_qubitsmethod toQasm3SubroutineProcessorfor improved qubit uniqueness validation across function calls.Qasm3Validator.Enhance
aliashandling in QASM by including alias register sizes for target qubit resolution and improving duplicate qubit validation for aliased arguments.Add a test case to validate dynamic indexed qubit aliases as function arguments.
Closes #80
Closes #108