Skip to content

Expand docs#150

Merged
geoffrey-wu merged 20 commits into
qbreader:mainfrom
skysomorphic:docs
Apr 26, 2023
Merged

Expand docs#150
geoffrey-wu merged 20 commits into
qbreader:mainfrom
skysomorphic:docs

Conversation

@skysomorphic
Copy link
Copy Markdown
Member

@skysomorphic skysomorphic commented Mar 28, 2023

Closes #143 when completed

click for pr summary

@skysomorphic skysomorphic changed the title Expand docs (#143) Expand docs Mar 28, 2023
@skysomorphic
Copy link
Copy Markdown
Member Author

RFC on this new API main page design?
Each endpoint would have its own page that can be accessed from the sidebar or clicking any of the description headings.

image

image

The actual docs of the endpoint is just a placeholder for now that I copied from the old page.

@geoffrey-wu
Copy link
Copy Markdown
Member

Looks perfect to me!

Comment thread server/schemas.js
@skysomorphic
Copy link
Copy Markdown
Member Author

quick question: is it stylized "QBReader", "QB Reader", "qbreader", or whatever else lol

@geoffrey-wu
Copy link
Copy Markdown
Member

quick question: is it stylized "QBReader", "QB Reader", "qbreader", or whatever else lol

I would go for QB Reader, but in honesty I'm not sure if anyone knows.

@geoffrey-wu
Copy link
Copy Markdown
Member

Any idea on when this will be completed? It looks very exciting 👀

@skysomorphic
Copy link
Copy Markdown
Member Author

got caught up in school will probably be done later this week!

@skysomorphic skysomorphic marked this pull request as ready for review April 24, 2023 14:28
@skysomorphic skysomorphic marked this pull request as draft April 24, 2023 14:58
@skysomorphic skysomorphic marked this pull request as ready for review April 24, 2023 15:48
@skysomorphic
Copy link
Copy Markdown
Member Author

skysomorphic commented Apr 24, 2023

I've gone back and checked out the up to date scss files and integrated any additions to the docs in main. It should be ok to override conflicting files with changes in this pr.

Copy link
Copy Markdown
Member Author

@skysomorphic skysomorphic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't include URL examples for requests, because I feel like that sort of thing can be easily done with tools like HTTPie, especially their web app. I'll definitely consider adding things like cookbooks and quickstarts if the API gets large enough though.

@skysomorphic
Copy link
Copy Markdown
Member Author

skysomorphic commented Apr 24, 2023

Summary

Changes

Notes and ideas for the future

  • Some of the endpoints return full objects while others only return arrays. I think it might be worth converting one that don't return objects (like api/check-answer) into returning objects for consistency and easier use for developers.
  • Many questions in the database are missing certian fields in the schema like formatted_answer, could definitely be a problem for devs expecting all fields to be complete.
  • Quickstarts and cookbooks
  • probably should change api/random-question to GET soon
  • accordion design???

@geoffrey-wu geoffrey-wu merged commit a365b75 into qbreader:main Apr 26, 2023
@geoffrey-wu geoffrey-wu mentioned this pull request Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand API Documentation

2 participants