Expand diacritics#157
Merged
Merged
Conversation
I was torn on weather to include greek characters, decided to include them.
skysomorphic
approved these changes
Apr 19, 2023
Member
skysomorphic
left a comment
skysomorphic
left a comment
There was a problem hiding this comment.
It might be worth considering adding multiletter transliterations in the future, such as:
German "ß" as "ss" or "sz"
Icelandic "þ" as "th"
Nordic "æ" as "ae"
Contributor
Author
|
something like |
Was talking with @geoffrey on discord; he wanted it limited to actuall diacritic
Member
|
Ran the backend tests; for searching cesaire 5 times, the old method took 16.285s, this method before any optimizations took 18.592s, and this method after optimizations took 15.355s. All of these times are well within error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was torn on weather to include greek characters, decided to include them.