feat: more detailed titles#513
Open
btfcookies wants to merge 1 commit into
Open
Conversation
Member
|
Could you undo your ip-filter related changes and rebase (rebasing isn't strictly necessary but is good for getting my ip filter changes to test locally) |
btfcookies
force-pushed
the
feat/specific-titles
branch
from
b520dc8 to
d32ab65
Compare
Contributor
Author
|
k fixed and rebased |
Member
|
Sorry to take this a different direction, but I'd prefer if each page just had a <title> tag with its title, and QBReader can be the default fallback title. You can do this by having the title tag appear before the server side include that has the title tag: <title>Page-Specific Title</title>
<!--#include virtual="/ssi/head.html" --> |
Contributor
Author
|
Ah ok ill change it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #494
Replaces general title tag in head.html with a
specificTitle()function that adds a subtitle based on the page the user is on.Notes:
i commented out parts of ipfilter.js that use the ip-bans collection
Also added a section in contributing.md that tells developers to comment out the parts of ipfilter.js that use the ip-bans collection.