Skip to content

Add support for dangvantuan/sentence-camembert-base#194

Closed
Ya-shh wants to merge 14 commits intoqdrant:mainfrom
Ya-shh:Sentence-Camembert_Base
Closed

Add support for dangvantuan/sentence-camembert-base#194
Ya-shh wants to merge 14 commits intoqdrant:mainfrom
Ya-shh:Sentence-Camembert_Base

Conversation

@Ya-shh
Copy link
Copy Markdown

@Ya-shh Ya-shh commented Apr 11, 2024

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Ya-shh
Copy link
Copy Markdown
Author

Ya-shh commented Apr 11, 2024

@Anush008 Only dangvantuan/sentence-camembert-base is being added

@Anush008
Copy link
Copy Markdown
Member

Seems the values from the ONNX weights are off.
You can try the https://huggingface.co/Xenova/sentence-camembert-large source.

@Ya-shh
Copy link
Copy Markdown
Author

Ya-shh commented Apr 11, 2024

Seems the values from the ONNX weights are off. You can try the https://huggingface.co/Xenova/sentence-camembert-large source.

Thanks 🚀@Anush008 !

@Ya-shh
Copy link
Copy Markdown
Author

Ya-shh commented Apr 11, 2024

@Anush008 now you could run the checks

@Ya-shh Ya-shh marked this pull request as draft April 11, 2024 20:14
@Ya-shh
Copy link
Copy Markdown
Author

Ya-shh commented Apr 11, 2024

@Anush008 I have quantised the model to onnx , interestingly this one has size of only 111 MB :https://huggingface.co/yashvardhan7/sentence-camembert-base_onnx/tree/main

@Ya-shh
Copy link
Copy Markdown
Author

Ya-shh commented Apr 11, 2024

Seems the values from the ONNX weights are off. You can try the https://huggingface.co/Xenova/sentence-camembert-large source.

The actual model is sentence-camembert-base, so the canonical values of this must be different .Additionally this is not listen in the issues. #137

@Ya-shh Ya-shh marked this pull request as ready for review April 11, 2024 20:43
@Ya-shh
Copy link
Copy Markdown
Author

Ya-shh commented Apr 12, 2024

@Anush008 it seems like tests are not able to recognise model_quantized.onnx .Instead they are looking for model.onnx or model_optimized.onnx. So I have updated the model to model.onnx .

@Ya-shh
Copy link
Copy Markdown
Author

Ya-shh commented Apr 12, 2024

@Ya-shh Ya-shh closed this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants