Skip to content

Periodic quality PR #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xwings merged 13 commits into from
Oct 10, 2022
Merged

Periodic quality PR #1238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
734e1ab
Relocate catch_KeyboardInterrupt and rename to hookcallback
elicn Sep 19, 2022
24b7373
Revisit propagation of emulation exceptions
elicn Sep 19, 2022
7cbe2b5
Make r2 extention tests depended on libr
elicn Sep 19, 2022
135560a
Minor linter-friendly tweaks
elicn Sep 28, 2022
9a9d592
Delay QlHost creation
elicn Sep 28, 2022
f498b6a
Make path and targetname properties dynamic
elicn Sep 28, 2022
207fd94
Redefine QlDebugger
elicn Sep 28, 2022
2bd8003
Better corner case handling for GetProcAddress
elicn Sep 28, 2022
6b9a418
Add hardware debug registers to x86 arch
elicn Oct 2, 2022
fa8a840
Improve core attributes documentation
elicn Oct 4, 2022
11e6370
Remove an obsolete DOS profile setting
elicn Oct 4, 2022
4ead520
Add ARM Qx and Sx registers
elicn Oct 6, 2022
0ea5fc4
Minor PEP8 and linter-friendly tweaks
elicn Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions qiling/arch/arch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env python3
#
#
# Cross Platform and Multi Architecture Advanced Binary Emulation Framework
#

Expand All @@ -15,6 +15,7 @@
from .register import QlRegisterManager
from .utils import QlArchUtils


class QlArch:
type: QL_ARCH
bits: int
Expand Down Expand Up @@ -57,7 +58,6 @@ def stack_push(self, value: int) -> int:

return self.regs.arch_sp


def stack_pop(self) -> int:
"""Pop a value from the architectural stack.

Expand All @@ -69,7 +69,6 @@ def stack_pop(self) -> int:

return data


def stack_read(self, offset: int) -> int:
"""Peek the architectural stack at a specified offset from its top, without affecting
the top of the stack.
Expand All @@ -86,7 +85,6 @@ def stack_read(self, offset: int) -> int:

return self.ql.mem.read_ptr(self.regs.arch_sp + offset)


def stack_write(self, offset: int, value: int) -> None:
"""Write a value to the architectural stack at a specified offset from its top, without
affecting the top of the stack.
Expand All @@ -101,17 +99,14 @@ def stack_write(self, offset: int, value: int) -> None:

self.ql.mem.write_ptr(self.regs.arch_sp + offset, value)


# Unicorn's CPU state save
def save(self) -> UcContext:
return self.uc.context_save()


# Unicorn's CPU state restore method
def restore(self, saved_context: UcContext):
self.uc.context_restore(saved_context)


@property
@abstractmethod
def disassembler(self) -> Cs:
Expand All @@ -120,7 +115,6 @@ def disassembler(self) -> Cs:

pass


@property
@abstractmethod
def assembler(self) -> Ks:
Expand All @@ -135,4 +129,4 @@ def endian(self) -> QL_ENDIAN:
"""Get processor endianess.
"""

pass
pass
7 changes: 5 additions & 2 deletions qiling/arch/arm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env python3
#
#
# Cross Platform and Multi Architecture Advanced Binary Emulation Framework
#

Expand All @@ -15,6 +15,7 @@
from qiling.arch.register import QlRegisterManager
from qiling.const import QL_ARCH, QL_ENDIAN


class QlArchARM(QlArch):
type = QL_ARCH.ARM
bits = 32
Expand Down Expand Up @@ -43,7 +44,9 @@ def uc(self) -> Uc:
def regs(self) -> QlRegisterManager:
regs_map = dict(
**arm_const.reg_map,
**arm_const.reg_vfp
**arm_const.reg_vfp,
**arm_const.reg_map_q,
**arm_const.reg_map_s
)

pc_reg = 'pc'
Expand Down
3 changes: 2 additions & 1 deletion qiling/arch/arm64.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env python3
#
#
# Cross Platform and Multi Architecture Advanced Binary Emulation Framework
#

Expand All @@ -14,6 +14,7 @@
from qiling.arch.register import QlRegisterManager
from qiling.const import QL_ARCH, QL_ENDIAN


class QlArchARM64(QlArch):
type = QL_ARCH.ARM64
bits = 64
Expand Down
Loading