fix null byte truncation in __place_input_wrapper#1503
Merged
Conversation
when using input_bytes.value, the input buffer will be truncated to the first null bytes encountered. a initial seed such as : b"\x04\x08\x00\x66" will be b"\x04\x08"
Member
|
Good catch! Ignore the failing tests, it is not related to your PR. |
Contributor
Author
yep didn't test input_bytes.raw but seem also working. |
…alue to prevent null byte truncation
xwings
approved these changes
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when using input_bytes.value, the input buffer will be truncated to the first null bytes encountered.
a initial seed such as : b"\x04\x08\x00\x66" will be b"\x04\x08"
Checklist
Which kind of PR do you create?
Coding convention?
Extra tests?
Changelog?
Target branch?
One last thing