Refactor qdb#1549
Conversation
|
@ucgJhe, would appreciate your feedback. |
There was a problem hiding this comment.
Here are all my reviews so far. As for the capstone engine issue, not quite sure anything will be broken if we upgrade it. Everything is fine after I upgraded my local version to capstone==5.0.5, and run tests/test_onlinux.sh.
I also pushed my solutions here: https://github.com/ucgJhe/qiling/tree/refactor-qdb
| brmark = f'{color.RED}{bmark}{color.RESET}' | ||
|
|
||
| trace_line = f"0x{insn.address:08x} │ {opcode:15s} {insn.mnemonic:10} {insn.op_str:35s}" | ||
| # <DEBUG> |
There was a problem hiding this comment.
maybe only show this messages when QL_VERBOSE is DEBUG ?
There was a problem hiding this comment.
I find the target indication quite informative actually.
Maybe change the message format to be more elegant?
There was a problem hiding this comment.
I'll figure something out.
There was a problem hiding this comment.
There's also another DEBUG message in render.py. Do you think thats also nessassary ?
There was a problem hiding this comment.
Snapshot diff prints removed.
ucgJhe
left a comment
There was a problem hiding this comment.
Looks good for me once it's fixed
|
Enabled
|
|
@elicn you approval is needed. |
Yes, I was thinking about renaming |
yes, rename to |
|
@xwings, we can merge now. |
qdb refactored from ground up, overall improving feature stability, reliability and maintainability.
Note: some debug prints are still present; waiting for feedback.
Highlights:
x/8i ($pc + $sp + (4 * $r1))TODO:
Screenshot 1: context dump, predicting branch taken upwards

Screenshot 2: examine command taking an expression as its argument
