Skip to content

Fix Windows breakage #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xwings merged 1 commit into from
Oct 30, 2025
Merged

Fix Windows breakage #1595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions qiling/loader/pe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,6 +644,7 @@ def init_imports(self, pe: pefile.PE, is_driver: bool):

# DLLs that seem to contain most of the requested symbols
key_dlls = (
'kernel32.dll',
'ntdll.dll',
'kernelbase.dll',
'ucrtbase.dll'
Expand Down
4 changes: 2 additions & 2 deletions tests/test_pe_sys.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,8 @@ def hook_third_stop_address(ql: Qiling, stops: List[bool]):
fcall.writeParams(((DWORD, 0),))

# run until third stop
# TODO: Should stop at 0x10423, but for now just stop at 0x0001066a
amsint32.hook_address(hook_third_stop_address, 0x0001066a, stops)
# TODO: Should stop at 0x10423, but for now just stop at 0x10430
amsint32.hook_address(hook_third_stop_address, 0x10430, stops)
amsint32.run(begin=0x102D0)

self.assertTrue(stops[0])
Expand Down