Skip to content

Add connectivity peripheral's base class#971

Merged
cla7aye15I4nd merged 13 commits into
qilingframework:devfrom
cla7aye15I4nd:dev
Oct 31, 2021
Merged

Add connectivity peripheral's base class#971
cla7aye15I4nd merged 13 commits into
qilingframework:devfrom
cla7aye15I4nd:dev

Conversation

@cla7aye15I4nd
Copy link
Copy Markdown
Member

@cla7aye15I4nd cla7aye15I4nd commented Oct 31, 2021

Checklist

Which kind of PR do you create?

  • This PR only contains minor fixes.
  • This PR contains major feature update.
  • This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • The new code conforms to Qiling Framework naming convention.
  • The imports are arranged properly.
  • Essential comments are added.
  • The reference of the new code is pointed out.

Extra tests?

  • No extra tests are needed for this PR.
  • I have added enough tests for this PR.
  • Tests will be added after some discussion and review.

Changelog?

  • This PR doesn't need to update Changelog.
  • Changelog will be updated after some proper review.
  • Changelog has been updated in my PR.

Target branch?

  • The target branch is dev branch.

One last thing


@cla7aye15I4nd cla7aye15I4nd merged commit 38564fd into qilingframework:dev Oct 31, 2021
Comment thread qiling/hw/connectivity.py
def recv(self, numb:int = 4096) -> bytes:
""" Receive data from peripheral

Example:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in comments? this should be recv ?

Comment thread qiling/hw/connectivity.py
@@ -0,0 +1,95 @@
#!/usr/bin/env python3
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can put this in qiling/hw/protocol or leave it in utils should be ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants