Implement stateful SimpleStringBuffer

[wtdcode]

Checklist

Which kind of PR do you create?

• This PR only contains minor fixes.
• This PR contains major feature update.
• This PR introduces a new function/api for Qiling Framework.

Coding convention?

• The new code conforms to Qiling Framework naming convention.
• The imports are arranged properly.
• Essential comments are added.
• The reference of the new code is pointed out.

Extra tests?

• No extra tests are needed for this PR.
• I have added enough tests for this PR.
• Tests will be added after some discussion and review.

Changelog?

• This PR doesn't need to update Changelog.
• Changelog will be updated after some proper review.
• Changelog has been updated in my PR.

Target branch?

• The target branch is dev branch.

One last thing

• I have read the contribution guide

---

[elicn]

@wtdcode, can you give a little bit of context around that fix..?

As stated on the SimpleStringBuffer docstring, it is a FIFO stream; being able to seek is a random access feature which breaks the FIFO property. That also requires storing the entire content of the stream throughout its lifetime (i.e. reading part of it doesn't let you get rid of that part), which becomes problematic when using it for stdout that may potentially yield tons of output.

Would you prefer to create a RandomStream class that supports seek, just like io.BufferedRandom ?

[wtdcode]

@wtdcode, can you give a little bit of context around that fix..?

As stated on the SimpleStringBuffer docstring, it is a FIFO stream; being able to seek is a random access feature which breaks the FIFO property. That also requires storing the entire content of the stream throughout its lifetime (i.e. reading part of it doesn't let you get rid of that part), which becomes problematic when using it for stdout that may potentially yield tons of output.

Would you prefer to create a BufferedStream class that supports seek, just like io.BufferedRandom ?

Yes, you are right. I would create another subclass.

[elicn]

Yes, you are right. I would create another subclass.

Consider adding:

def seekable(self) -> bool:
    return True

To indicate it is a seek-able stream.

[elicn]

Not sure, but I think @wtdcode wanted to create another PR instead of this one.

[wtdcode]

Yes, indeed

…

________________________________ From: Eli ***@***.***> Sent: Thursday, November 25, 2021 12:51:48 PM To: qilingframework/qiling ***@***.***> Cc: lazymio ***@***.***>; Mention ***@***.***> Subject: Re: [qilingframework/qiling] Implement stateful SimpleStringBuffer (PR #992) Not sure, but I think @wtdcode<https://github.com/wtdcode> wanted to create another PR instead of this one. ― You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#992 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHJULO6FFCDQ2GM7LFCKFV3UNYPNJANCNFSM5HXYR4TQ>.

[wtdcode]

Closed due to #1071