Skip to content

Add Windows support #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
govindchari merged 2 commits into from
Mar 19, 2025
Merged

Add Windows support #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3e2527
Add windows support
govindchari Mar 19, 2025
9a35d46
Add windows build for wheels
govindchari Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-13, macos-latest]
os: [ubuntu-latest, macos-13, macos-latest, windows-latest]

steps:
- uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/unit_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ jobs:
# This workflow contains a single job called "build"
build:
# The type of runner that the job will run on
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}

strategy:
# Set fail-fast to false to ensure that feedback is delivered for all matrix combinations. Consider changing this to true when your workflow is stable.
fail-fast: false

matrix:
os: [ubuntu-latest]
os: [ubuntu-latest, macos-13, windows-latest]

# Steps represent a sequence of tasks that will be executed as part of the job
steps:
Expand Down
4 changes: 3 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ if(${CMAKE_SYSTEM_NAME} STREQUAL "Linux")
add_compile_definitions(IS_LINUX)
elseif(${CMAKE_SYSTEM_NAME} STREQUAL "Darwin")
add_compile_definitions(IS_MACOS)
elseif(${CMAKE_SYSTEM_NAME} STREQUAL "Windows")
add_compile_definitions(IS_WINDOWS)
endif()

find_package(pybind11 REQUIRED)
Expand All @@ -21,7 +23,7 @@ include(FetchContent)
FetchContent_Declare(
qoco
GIT_REPOSITORY https://github.com/qoco-org/qoco.git
GIT_TAG d2bbfc5d2d921242e4e94e4a2254d7adec3632b4
GIT_TAG 251303fbb62e4f225170051c2a5f18fcc14c808f
)

list(POP_BACK CMAKE_MESSAGE_INDENT)
Expand Down