[CORRUPTED] Synthetic Benchmark PR #73604 - Refactor deleteReportComment() to use useAncestors hook#116
Open
tomerqodo wants to merge 25 commits intobase_pr_73604_20251231_9428from
Open
Conversation
- Implemented getOptimisticDataForAncestors to handle optimistic updates for ancestor reports. - Updated deleteReportComment and editReportComment functions to utilize the new ancestors parameter. - Modified PopoverReportActionContextMenu and ReportActionItemMessageEdit components to fetch ancestors. - Enhanced tests in ReportTest to validate changes with ancestors.
…or ancestor calculations
…arity and performance
…nsify-App into deleteReportComment
This reverts commit 4ab7817.
…cestors from changes in recent main merge commit Refactor comments and update optimistic data handling for ancestor report actions.
This was referenced Dec 31, 2025
Open
Open
This was referenced Jan 6, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR Expensify#73604
Type: Corrupted (contains bugs)
Original PR Title: Refactor
deleteReportComment()to use useAncestors hookOriginal PR Description:
Explanation of Change
Refactoring
deleteReportCommentinto a pure function.Fixed Issues
$ Expensify#73568
PROPOSAL:
Tests
Force Offline.2 replies.1 reply.Force Offline.Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
Android.-.mWeb.webm
iOS: Native
iOS.-.Native.mp4
iOS: mWeb Safari
iOS.-.Safari.mp4
MacOS: Chrome / Safari
macOS.-.Chrome.mov
MacOS: Desktop
Original PR URL: Expensify#73604