Skip to content

Extract IKurrentDbSubscriber#13

Closed
SamBucaMatthews wants to merge 24 commits intomasterfrom
extract-interface
Closed

Extract IKurrentDbSubscriber#13
SamBucaMatthews wants to merge 24 commits intomasterfrom
extract-interface

Conversation

@SamBucaMatthews
Copy link
Copy Markdown
Member

@SamBucaMatthews SamBucaMatthews commented Dec 8, 2022

Extract IKurrentDbSubscriber

This pull request extracts IKurrentDbSubscriber in order to make testing client applications simpler.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 8, 2022

Pull Request Review Checklist:

  • Variable have been given sensible, meaningful names.
  • LINQ to SQL datacontexts must always be initialised with an explicit connection string drawn from a config file.
  • Code is DRY (Dont Repeat Yourself). (But make sure where this is applied, the two things are actually the same!)
  • No values have been hard-coded where they should be drawn from a config file.
  • Comments are present where appropriate, and provide useful information not just stating what the code is obviously doing.
  • Error handling is performed appropriately where things might fail.
  • Logging is present, useful, and uses log levels appropriately.
  • If new app config values are referenced in the code, a placeholder must be committed in the config file.
  • If new app config values are referenced in the code, they must be added to octopus before approving this PR.
  • For projects with snapshotting, any new fields added to viewmodels must declare datamembers appropriately.
  • For projects with snapshotting, any new viewmodels should be added to the snapshot load/save code in the bootstrapper.

@SamBucaMatthews SamBucaMatthews changed the base branch from master to PC-8075-LibraryUpdate May 30, 2025 09:08
@SamBucaMatthews SamBucaMatthews changed the title Extract IEventStoreSubscriber Extract IKurrentDbSubscriber May 30, 2025
ChrisF-Pharmaxo and others added 3 commits May 30, 2025 11:59
Base automatically changed from PC-8075-LibraryUpdate to master June 6, 2025 14:57
Copy link
Copy Markdown
Contributor

@danieljayne danieljayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some conflicts to resolve

@SamBucaMatthews SamBucaMatthews deleted the extract-interface branch June 12, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants