MAINT: Move sparsehash code to library_wrappers/sparsehash #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llllllllll
reviewed
Jul 2, 2020
Contributor
llllllllll
left a comment
llllllllll
left a comment
There was a problem hiding this comment.
We currently have wrappers in the py namespace for sparsehash which change the constructor of sparsehash to ensure that the empty key is passed for dense hash map. Only these subclasses are adapted. I think it is fine to leave these helper types; however, we should add (to|from)_object converters for the base sparsehash types.
added 3 commits
July 2, 2020 14:39
llllllllll
reviewed
Jul 2, 2020
added 2 commits
July 2, 2020 18:23
llllllllll
reviewed
Jul 2, 2020
llllllllll
reviewed
Jul 2, 2020
llllllllll
approved these changes
Jul 2, 2020
Contributor
llllllllll
left a comment
llllllllll
left a comment
There was a problem hiding this comment.
we can kill two comments but otherwise LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step in #172.
Also good example for how to create a wrapper for libpy.
TODO: Once agreed, README, etc.