General maintenance#10
Merged
Merged
Conversation
The automatic `Try "<command> --help" for help.` output text was added in Click 7.0. This commit changes the tests to only check the portion of the output under our control.
Apparently Travis still only offers 3.7-dev. We should fix this once a stable 3.7 is available.
Resolves the following two DeprecationWarnings from traitlets 4.1:
DeprecationWarning: Traits should be given as instances, not types
(for example, `Int()`, not `Int`). Passing types is deprecated in
traitlets 4.1.
DeprecationWarning: metadata {'example': 97} was set from the
constructor. With traitlets 4.1, metadata should be set using the
.tag() method, e.g., Int().tag(key1='value1', key2='value2')
ssanderson
reviewed
Dec 6, 2018
Contributor
ssanderson
left a comment
ssanderson
left a comment
There was a problem hiding this comment.
Took a quick pass at this. Just had a few questions.
| testpaths = straitlets | ||
| filterwarnings = | ||
| # PyYAML==3.13 | ||
| ignore:Using or importing the ABCs:DeprecationWarning:yaml.constructor:126 |
Contributor
There was a problem hiding this comment.
What are these two warnings about?
Contributor
Author
There was a problem hiding this comment.
Only one warning, from PyYAML. Full output:
straitlets/ext/tests/test_click.py::test_yaml_file
site-packages/yaml/constructor.py:126: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
if not isinstance(key, collections.Hashable):
We require pyyaml>=3.11, so it should go away once it's fixed upstream. There's a couple open PRs with a fix already.
Apparently there is a Situation with PyYAML releases that we might want to keep an eye on, though: see yaml/pyyaml#193, yaml/pyyaml#194.
richafrank
reviewed
Dec 6, 2018
| - if [[ $TRAVIS_PYTHON_VERSION = '3.4' ]]; then tox -e py34; fi | ||
| - if [[ $TRAVIS_PYTHON_VERSION = '3.5' ]]; then tox -e py35; fi | ||
| - if [[ $TRAVIS_PYTHON_VERSION = '3.6' ]]; then tox -e py36; fi | ||
| - if [[ $TRAVIS_PYTHON_VERSION = '3.7-dev' ]]; then tox -e py37; fi |
Contributor
There was a problem hiding this comment.
We could also look at using https://github.com/tox-dev/tox-travis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: