WIP: refactor python-bindiff #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I added docstrings for the new functions, used single leading underscore for private methods instead of double leading underscore that has a specific behavior, invoking name mangling (see PEP-8) and fixed a leftover. |
patacca
force-pushed
the
refactor-diffing
branch
from
66bdca6 to
d723b70
Compare
Collaborator
|
Rebased on top of main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework completely the underlying of diffs to better scale.
I am not mutating objects on the fly now.
Changed the API to make it compliant with the underlying working of python-binexport.
Can now instanciate a
BinDiffobject almost immediately.(Now need to write some tests)