Correctly check for sidebar.logo in EJS template

[cderv]

sidebar.logo is now normalized as an object with light and dark properties

So sidebar.logo is never undefined - it may have light or dark undefined, but the object itself exists.

fix #13506

[posit-snyk-bot]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Licenses	0	0	0	0	0 issues
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[cderv]

While trying to add some tests, I am now wondering how we are supposed to pass logo when we do hybrid navigation: https://quarto.org/docs/websites/website-navigation.html#hybrid-navigation

• one logo per sidebar ?
• one logo for all sidebar ?

🤔

[gordonwoodhull]

As discussed, we are only resolving the logos in sidebars[0], but we should probably resolve logos in all sidebars:

quarto-cli/src/project/types/website/website-shared.ts

Lines 174 to 208 in 4262320

	let sideLogo = sidebars[0].logo;
	if (sideLogo) {
	if (sidebars[0][kLogoAlt]) {
	const alt = sidebars[0][kLogoAlt];
	if (typeof sideLogo === "string") {
	sideLogo = { path: sideLogo, alt };
	}
	// possible but absurd
	// else if ("path" in sideLogo) {
	// sideLogo = { ...sideLogo, alt };
	// } else {
	// sideLogo = {
	// light: !sideLogo.light ? undefined : typeof sideLogo.light === "string"
	// ? {
	// path: sideLogo.light,
	// alt,
	// }
	// : { ...sideLogo.light, alt },
	// dark: !sideLogo.dark ? undefined : typeof sideLogo.dark === "string"
	// ? {
	// path: sideLogo.dark,
	// alt,
	// }
	// : { ...sideLogo.dark, alt },
	// };
	// }
	}
	}
	let logo = resolveLogo(projectBrand, sideLogo, [
	"medium",
	"small",
	"large",
	]);
	logo = logoAddLeadingSlashes(logo, projectBrand, undefined);
	sidebars[0].logo = logo;

[cderv]

Thanks. That is explaining it ! Surely not clear from the doc !

I think I'll handle it in another issue

[cderv]

setting sidebar.logo to undefined required to properly handle the logo in Typst Lua brand support. Our test caught it which is cool!