Fix Pdf Export mode menu button and keyboard shortcut#4676
Merged
dragonstyle merged 5 commits intomainfrom Mar 8, 2023
Merged
Conversation
This will enable toggling PDF export mode using API
…nu and keyboard shortcut
dragonstyle
approved these changes
Mar 8, 2023
Collaborator
dragonstyle
left a comment
dragonstyle
left a comment
There was a problem hiding this comment.
Love that you automated the patch process!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix #2988
We patch RevealJS plugin PdfExport so that the toggle function is exported. This allow us to assign it as handler to our menu logic and keyboard shortcut.
To make things clean, the patching of external library is done using a Git Patch, so I added support for that in update-html-dependencies logic.
This PR also adds a prettier configuration file for ignoring some file from the VSCODE auto formatting as we don't want to touch those in our commit tree since they are external.
A mixed PR but all related to the bug fix.