Fix no inspectable targets issue with Chrome Browser

[cderv]

Fix #4653

Issue is that somehow Chrome browser open in headless mode with no target available at json/ endpoint.

The logic to solve is to create a new tab if no target is already available. This way there will be a new target with websocket url to use.

Another solution would be to default to json/version endpoint (devtools.Version(option) from devtools.js) to get the browser websocket url

But it feels like the former is good enough and better as we prefer page type for the ws url, so I went with that.

This PR will add to the defaultTarget() handler the creation of a new tab using json/new if no targets is to inspect.
I wasn't sure where to put this here or not, we could also move it upper in the stack in _fetchDebuggerURL() directly, instead of only defaultTarget(). It would be more generic.

This PR also fix an issue I found while working on it - if client is created without error, no need to try maxTries (5) times

Hope this is good. Not sure how to add tests for this quite specific fix.

Tested locally and it works for me.

[cscheid]

with respect to changes on chrome.js: you'll note that this is a port of a library written by someone else. Fantastic that you found the issue and fixed it.

But I wonder if we should also check the upstream for updates, and set up a more formal fork rather than just change this one directly. (We can do that during 1.4)

[cscheid]

Not sure how to add tests for this quite specific fix.

This code path should be getting tested during our mermaid rendering tests. Ideally we'd make an isolated test, but I think we're at least covered.

[cderv]

with respect to changes on chrome.js: you'll note that this is a port of a library written by someone else. Fantastic that you found the issue and fixed it.

But I wonder if we should also check the upstream for updates, and set up a more formal fork rather than just change this one directly. (We can do that during 1.4)

I did not realize this one file from a library 🤦 it was in core so I thought it was ours but now I see the head of the file and the copyright and author 😅

Do you know the repo for this ? I can PR there maybe

Otherwise in #4704 we can do a git patch approach as I recently add to updateGithubSourceCodeDependency for PdfExport plugin in Reveal

quarto-cli/package/src/common/update-html-dependencies.ts

Line 826 in 3e3ddea

if (patches) await applyGitPatches(patches)

[cscheid]

@cderv The facepalm is mine! I made the port, so I should know. But I don't remember. It shouldn't be hard to find.

[cderv]

This one probably : https://github.com/cyrus-and/chrome-remote-interface ?